Would be great if we can get more readers to help review

Anyone has interest in helping to review and give feedback? @zhiics @yzhliu @tqchen Thanks.

It would be great if we can add a figure explaining the storage relation and data structure.

It would be great if we can add a figure explaining the storage relation and data structure.

Will do.

It would be great if we can add a figure explaining the storage relation and data structure.

Will do.

@tqchen need to double check to make sure I understand correctly.

The doc describes:

• Module import relationship. i.e. LLVM imports cuda module. <- No need to have figure in my opinion as it only have two modules and is a simple relationship

• Serialization Format.

binary_blob_size
binary_blob_type_key
binary_blob_logic
...
_import_tree
_import_tree_logic

<- No need to have figure, as this simple table could describe cleanly.

• Mark Module Index. We have LLVM Module (0, root module) <- CUDA Module (1). <- No need to have figure.

• import tree of CSR storage. Each row is parent index, each col is child indices. <- We need to have figure to describe what is CSR module index mapping status. Like this figure: https://img-blog.csdn.net/2018092717062821?watermark/2/text/aHR0cHM6Ly9ibG9nLmNzZG4ubmV0L2dhb2Jvcmw=/font/5a6L5L2T/fontsize/400/fill/I0JBQkFCMA==/dissolve/70

sounds good, would love to see others' thoughts, @zhiics @yzhliu @ajtulloch @ZihengJiang

Thanks the comment and suggestion of @zhiics @yzhliu @yangjunpro I will address the comment in the following days.

Have addressed the comments. I also add some words of PackImportToC existed in the PR #4657 , so we should be better handle it after that PR in.

ping @zhiics @yzhliu @FrozenGene @yangjunpro please followup on this thread :)

LGTM now. I will wait till tomorrow to see if there are any more comments.

Thanks everyone. This is now merged.